Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(franka_gazebo): fix 'set_franka_model_configuration' srv #380

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Mar 24, 2024

This pull request fixes a problem that was introduced when https://github.com/rickstaa/franka_ros/tree/fix_gazebo_set_model_config_problem was rebased onto the develop branch in #226. The force push resulting from this rebase unfortunatelly removed the code that setsup the service.

This commit fixes a problem that was introduced when
https://github.com/rickstaa/franka_ros/tree/fix_gazebo_set_model_config_problem
was rebased onto the `develop` branch in frankaemika#226. The force push resulting
from this rebase unfortunatelly removed the code that setsup the
service.
@rickstaa
Copy link
Contributor Author

@BarisYazici, just a quick note to make your review easier: the commit from the rebase that caused the issue in #226 is here. Thanks for checking this out!

rickstaa added a commit to rickstaa/panda-gazebo that referenced this pull request Mar 24, 2024
This commit updates the 'franka_ros' branch to ensure the
'set_franka_model_configuration' service is published (see
frankaemika/franka_ros#380).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant