Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superfluous JSON/XML tagging in PaymentManager #343

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

evrimoztamur
Copy link
Contributor

Hi team,

When testing payment deletions for a feature I am implementing for a live app (batch2sepa), I noticed that the PaymentManager._delete(self, id) was adding in a wrapping dictionary. This makes the request body get processed as a query encoded string. Xero, granted, fails to parse the body and returns a 500:

image

I only noticed this after checking the app history, making the change in the attached commit leads to the issue being resolved and the payments being deleted correctly.

Let me know if you need any additional information. I hope this will get admitted swiftly!

Kind regards,

Evrim Öztamur

Copy link
Owner

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@freakboy3742 freakboy3742 merged commit b64cea0 into freakboy3742:main Sep 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants