Remove dead browser visible methods

Signed-off-by: Andreas Tolfsen <ato@mozilla.com>
freddyvega · Mar 26, 2014 · e804d9b · e804d9b
1 parent fceda53
commit e804d9b
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 32 deletions.
diff --git a/java/client/src/org/openqa/selenium/remote/DriverCommand.java b/java/client/src/org/openqa/selenium/remote/DriverCommand.java
@@ -75,9 +75,6 @@ public interface DriverCommand {
   String EXECUTE_SCRIPT = "executeScript";
   String EXECUTE_ASYNC_SCRIPT = "executeAsyncScript";
 
-  String SET_BROWSER_VISIBLE = "setBrowserVisible";
-  String IS_BROWSER_VISIBLE = "isBrowserVisible";
-
   String GET_ELEMENT_TEXT = "getElementText";
   String GET_ELEMENT_VALUE = "getElementValue";
   String GET_ELEMENT_TAG_NAME = "getElementTagName";

diff --git a/java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java b/java/client/src/org/openqa/selenium/remote/HttpCommandExecutor.java
@@ -147,8 +147,6 @@ public HttpCommandExecutor(Map<String, CommandInfo> additionalCommands, URL addr
         .put(GET_TITLE, get("/session/:sessionId/title"))
         .put(GET_PAGE_SOURCE, get("/session/:sessionId/source"))
         .put(SCREENSHOT, get("/session/:sessionId/screenshot"))
-        .put(SET_BROWSER_VISIBLE, post("/session/:sessionId/visible"))
-        .put(IS_BROWSER_VISIBLE, get("/session/:sessionId/visible"))
         .put(FIND_ELEMENT, post("/session/:sessionId/element"))
         .put(FIND_ELEMENTS, post("/session/:sessionId/elements"))
         .put(GET_ACTIVE_ELEMENT, post("/session/:sessionId/element/active"))

diff --git a/py/selenium/webdriver/remote/command.py b/py/selenium/webdriver/remote/command.py
@@ -65,8 +65,6 @@ class Command(object):
     GET_PAGE_SOURCE = "getPageSource"
     GET_TITLE = "getTitle"
     EXECUTE_SCRIPT = "executeScript"
-    SET_BROWSER_VISIBLE = "setBrowserVisible"
-    IS_BROWSER_VISIBLE = "isBrowserVisible"
     GET_ELEMENT_TEXT = "getElementText"
     GET_ELEMENT_VALUE = "getElementValue"
     GET_ELEMENT_TAG_NAME = "getElementTagName"

diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py
@@ -175,9 +175,6 @@ def __init__(self, remote_server_addr, keep_alive=False):
             Command.GET_TITLE: ('GET', '/session/$sessionId/title'),
             Command.GET_PAGE_SOURCE: ('GET', '/session/$sessionId/source'),
             Command.SCREENSHOT: ('GET', '/session/$sessionId/screenshot'),
-            Command.SET_BROWSER_VISIBLE:
-                ('POST', '/session/$sessionId/visible'),
-            Command.IS_BROWSER_VISIBLE: ('GET', '/session/$sessionId/visible'),
             Command.FIND_ELEMENT: ('POST', '/session/$sessionId/element'),
             Command.FIND_ELEMENTS: ('POST', '/session/$sessionId/elements'),
             Command.GET_ACTIVE_ELEMENT:

diff --git a/rb/lib/selenium/webdriver/common/driver.rb b/rb/lib/selenium/webdriver/common/driver.rb
@@ -140,26 +140,6 @@ def page_source
         bridge.getPageSource
       end
 
-      #
-      # Get the visibility of the browser. Not applicable for all browsers.
-      #
-      # @return [Boolean]
-      #
-
-      def visible?
-        bridge.getBrowserVisible
-      end
-
-      #
-      # Set the visibility of the browser. Not applicable for all browsers.
-      #
-      # @param [Boolean]
-      #
-
-      def visible=(bool)
-        bridge.setBrowserVisible bool
-      end
-
       #
       # Quit the browser
       #

diff --git a/rb/lib/selenium/webdriver/remote/commands.rb b/rb/lib/selenium/webdriver/remote/commands.rb
@@ -20,8 +20,6 @@ class Selenium::WebDriver::Remote::Bridge
   command :refresh,                                :post,    "session/:session_id/refresh"
   command :quit,                                   :delete,  "session/:session_id"
   command :close,                                  :delete,  "session/:session_id/window"
-  command :getVisible,                             :get,     "session/:session_id/visible"
-  command :setVisible,                             :post,    "session/:session_id/visible"
   command :getPageSource,                          :get,     "session/:session_id/source"
   command :getTitle,                               :get,     "session/:session_id/title"
   command :findElement,                            :post,    "session/:session_id/element"