Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari support: every host permission is reported as "additional" #1

Closed
fregante opened this issue Oct 22, 2020 · 4 comments · Fixed by #3
Closed

Safari support: every host permission is reported as "additional" #1

fregante opened this issue Oct 22, 2020 · 4 comments · Fixed by #3
Labels
help wanted Extra attention is needed safari Related to Safari only

Comments

@fregante
Copy link
Owner

This appears to be the case from initial trials. Further testing needed.

@fregante fregante added bug Something isn't working help wanted Extra attention is needed labels Oct 22, 2020
@fregante
Copy link
Owner Author

Figured it out: Safari’s permissions are stored as *://*.github.com/*, which might not be a direct match with what's in the permissions key

@fregante
Copy link
Owner Author

fregante commented Dec 18, 2020

Technically the current situation is correct. *://*.github.com/* is different from *://github.com/* so it is, in fact, an "additional" permission.

The correct solution is to change the manifest.json permission to what Safari gives access to, but I'm afraid that it will trigger a warning in Chrome.

Testing needed

Edit: testing is hard, but I'm confident that prepending *. to the host is a substantial change.

@fregante
Copy link
Owner Author

I’ll implement loose host matching with an option, so only the domain is considered when comparing permissions and nothing else.

@fregante fregante removed the bug Something isn't working label Dec 19, 2020
@fregante
Copy link
Owner Author

fregante commented Dec 19, 2020

fregante added a commit to fregante/webext-options-sync-per-domain that referenced this issue Dec 19, 2020
If you requested an extended permission of a domain already in the manifest, it would be considered a whole new "domain".

This was due to fregante/webext-permissions#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed safari Related to Safari only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant