Add tests for subdomain wildcard #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Switching to draft as I may have missed something here as |
Add https://*.hassubdomains.com/* to the test manifests, to prove that subdomain matching is already working correctly, and allow for other tests relating to subdomains.
…sions According to the documentation, `strictOrigins` is only concerned with widening of permissions, not additional permissions which are narrower than a pattern already in the manifest origins. However, if `https://subdomain.hassubdomains.com/*` is granted by the user as an optional permission on top of `https://*.hassubdomains.com/*`, this does not change the effective set of permissions. So to be consistent with the documentation, when `strictOrigins` is `true`, the additional subdomain pattern should not be included in the return value of `extractAdditionalPermissions()`. Adding a test based on this expectation causes a failure, showing the current problem. So either the code should be changed, or the documentation for `strictOrigins` expanded to clarify that it also catches narrower permissions as well as wider ones.
…l permissions" This reverts commit dce4ca2.
fregante
changed the title
fregante
changed the title
isUrlPermittedByManifest - Add tests for subdomain wildcard
fregante
changed the title
isUrlPermittedByManifest - Add tests for subdomain wildcard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
https://*.hassubdomains.com/*to the test manifests, to prove that subdomain matching is already working correctly, and allow for other tests relating to subdomains (see #23).