chore(upgrade): v0.9.43 to v1.0.0 #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1700 +/- ##
==========================================
+ Coverage 83.09% 87.88% +4.78%
==========================================
Files 47 50 +3
Lines 4491 4241 -250
==========================================
- Hits 3732 3727 -5
+ Misses 759 514 -245
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
github-actions
bot
added
metadata-changed
github-actions
bot
removed
metadata-changed
github-actions
bot
added
metadata-changed
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
github-actions
bot
added
the
metadata-changed
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 0270497. |
demisx
pushed a commit
that referenced
this pull request
Oct 10, 2023
github-actions
bot
added
metadata-changed
JoeCap08055
reviewed
Oct 11, 2023
|
lgtm, but I won't approve just yet so others have time to review; also, I maybe don't have as much context for some of the changes. lmk if this hangs out & you need an approval, though. Also, thank you Rust for making it so we need 2 different toolchain versions 😐 |
enddynayn
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
from
1078773
to
80e507e
Compare
github-actions
bot
added
metadata-changed
|
⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion... |
|
✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 16a1c4b. |
demisx
pushed a commit
that referenced
this pull request
Oct 19, 2023
github-actions
bot
added
the
metadata-changed
enddynayn
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
from
16a1c4b
to
adff621
Compare
github-actions
bot
removed
the
metadata-changed
github-actions
bot
added
the
metadata-changed
github-actions
bot
removed
the
metadata-changed
mattheworris
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
from
f1ec2bc
to
19ef6a7
Compare
wilwade
reviewed
Oct 20, 2023
mattheworris
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
from
19ef6a7
to
76429e1
Compare
saraswatpuneet
approved these changes
Oct 20, 2023
mattheworris
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
2 times, most recently
from
459f414
to
2fb03c6
Compare
The goal of this PR is to upgrade to Polkadot v1.0.0 Notable changes: - The docker images for the local relay network have been updated to v1.1.0 to accurately reflect the last working version of Rococo-testnet. - ci-base-image has been updated to install the stable and nightly toolchains. References - [Polkadot Forum Release Notes](https://forum.polkadot.network/t/polkadot-release-analysis-v1-0-0/3585) - [V1.0.0 Release Tag](https://github.com/paritytech/polkadot/releases/tag/v1.0.0) - [Polkadot-v0.9.43 vs Polkadot-v1.0.0 difference](paritytech/substrate@polkadot-v0.9.43...polkadot-v1.0.0#diff-e5be9978262555d1f400caa5ae803ffc96be0ba25fd4ed8bd917c12529474c44R105) issue-1639 issue-1605
mattheworris
force-pushed
the
1639-upgrade-to-polkadot-release-v100
branch
from
a3a2add
to
559180e
Compare
github-actions
bot
added
the
metadata-changed
mattheworris
pushed a commit
that referenced
this pull request
Oct 24, 2023
This PR aims to remove the `rustup install toolchain nightly` commands from the individual GitHub jobs that use the `ci-base-image` that previously did not have the `nightly` toolchain. Closes #1727 # Discussion The changes in the previous PR (#1700) to add the `nightly` toolchain to `ci-base-image` were not published to DockerHub until the `merge-pr.yml` workflow actions were successfully run. Therefore the `nightly` toolchain was not available for CI to use in `ci-base-image`. In that PR, the `nightly` toolchain was installed in the individual jobs where it was needed to pass CI. Now that the PR has been merged, `ci-base-image` has been updated with both the `stable` and `nightly` toolchains and the redundant `rustup install` commands can be removed from `verify-pr-commit.yml`.
mattheworris
added a commit
that referenced
this pull request
Oct 25, 2023
…ci-base-image update (#1728) # Goal This PR aims to remove the `rustup install toolchain nightly` commands from the individual GitHub jobs that use the `ci-base-image` that previously did not have the `nightly` toolchain. Closes #1727 # Discussion The changes in the previous PR (#1700) to add the `nightly` toolchain to `ci-base-image` were not published to DockerHub until the `merge-pr.yml` workflow actions were successfully run. Therefore the `nightly` toolchain was not available for CI to use in `ci-base-image`. In that PR, the `nightly` toolchain was installed in the individual jobs where it was needed to pass CI. Now that the PR has been merged, `ci-base-image` has been updated with both the `stable` and `nightly` toolchains and the redundant `rustup install` commands can be removed from `verify-pr-commit.yml`. Co-authored-by: Matthew Orris <--help>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to upgrade to Polkadot v1.0.0
Notable changes:
The docker images for the local relay network have been updated to
v1.1.0 to accurately reflect the last working version of Rococo-testnet.
ci-base-image has been updated to install the stable and nightly
toolchains.
References
Closes #1639
Closes #1605
Checklist