Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relic locator #545

Merged
merged 23 commits into from
Sep 10, 2024
Merged

feat: relic locator #545

merged 23 commits into from
Sep 10, 2024

Conversation

FI00ds
Copy link
Contributor

@FI00ds FI00ds commented Aug 29, 2024 •
edited
Loading

Pull Request

Description

  • Added a location indicator to the relics tab that tells the user where in their in game inventory they can find the relic
  • Added accompanying hints

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

firefox_2024-08-31_09-06-14
firefox_2024-08-31_09-06-28
firefox_2024-08-31_09-08-25

@FI00ds FI00ds changed the base branch from main to beta August 29, 2024 12:57
@FI00ds
fix: default inventoryWidth on save file load
0f92590
@FI00ds
tests
f1212cd
@FI00ds
fix: timestamp manually added relic
4c0fbb7 
more accurate column name as maintaining oldest import date would require a rewrite of the relic matching in mergeRelicsWithState
@FI00ds
cleanup
817ca4c
@FI00ds FI00ds changed the base branch from beta to main August 30, 2024 13:59
@FI00ds FI00ds changed the base branch from main to beta August 30, 2024 13:59
@FI00ds FI00ds marked this pull request as draft August 30, 2024 16:02
@FI00ds FI00ds marked this pull request as ready for review August 30, 2024 20:39
fribbels
fribbels reviewed Aug 31, 2024
View reviewed changes
src/lib/db.js Outdated Show resolved Hide resolved
fribbels
fribbels reviewed Aug 31, 2024
View reviewed changes
src/lib/saveState.js Outdated Show resolved Hide resolved
@fribbels
Copy link
Owner

fribbels commented Sep 2, 2024

Nice, the functionality looks good now. I'm going to hold off on merging this one until after the 2.6 beta / 2.5 patch for whenever reliquary updates

@fribbels
Copy link
Owner

fribbels commented Sep 9, 2024

Will take up the ui refactor & merge this week

@fribbels
Copy link
Owner

image

image

@fribbels fribbels merged commit 6f4872f into fribbels:beta Sep 10, 2024
1 check passed
@FI00ds FI00ds deleted the feat/relic-locator branch September 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fribbels fribbels fribbels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Relic locator
2 participants
@FI00ds @fribbels