Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inclusion #590

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Fix inclusion #590

merged 3 commits into from
Jun 26, 2022

Conversation

fronzbot
Copy link
Owner

Description:

If a single sync module has a mix of camera type attached (any combo of normal, doorbell, mini), the type property would retain the previous state. Some tests were added to check for this as well as a small code modification. It may not fix any problems, but should be the routine more robust anyhow.

Related issue (if applicable): Possibly impacts #580 , TBD

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #590 (e8af309) into dev (9315c43) will increase coverage by 0.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #590      +/-   ##
==========================================
+ Coverage   86.27%   86.84%   +0.56%     
==========================================
  Files           8        8              
  Lines        1064     1064              
==========================================
+ Hits          918      924       +6     
+ Misses        146      140       -6     
Flag Coverage Δ
unittests 86.84% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/blinkpy.py 84.89% <ø> (ø)
blinkpy/sync_module.py 93.91% <ø> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9315c43...e8af309. Read the comment docs.

@fronzbot fronzbot merged commit d87d960 into dev Jun 26, 2022
@fronzbot fronzbot deleted the fix-inclusion branch June 26, 2022 18:44
@fronzbot fronzbot mentioned this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant