Changing coverlet output format to receive a list of formats

[lucasteles]

Description

Shoud be possible to pass multiples output formats to coverlet

See here

fixes #2563

[lucasteles]

I cant figure why the build broke

[github-actions]

There has not been any activity in this pull request for the last 3 months so it will be closed in 14 days if there is no activity.

[yazeedobaid]

The build for this PR should be fixed now after merging #2574.

[lucasteles]

@yazeedobaid it worked! thanks! can you review this?

[yazeedobaid]

@lucasteles Thanks for the update!
Here my notes on the PR:

1. As mentioned in the issue for this PR, if output formats have multiple values it should enclose them in quotes and escape these quotes. Please see Coverlet documentation page. Also as I understand Coverlet in FAKE is used with dotnet test command, so the escaping should not affect Linux or build environments per this note in Coverlet documentation also?
2. The API now accepts a list of output formats, so users who use the module need to update their code to make the output format argument passed as a list, even if they use one output format. I'm not sure but this introduces a breaking change to the API. What do you think?

Thanks

[lucasteles]

Thanks @yazeedobaid !

1 - About the escape quotes, I thought that FAKE already do that because other comma separated params are not escaped inside the command construction, but I do not checked it in the code tho, am I wrong?

2 - Yeah, I see this as a breaking change, we could create other property which is a list of outputs types and keep the old way too, so when we have a list we prioritise it, when not, just use the old single output. But this can turn the API a bit confusing. WDYT?

[yazeedobaid]

@lucasteles Thanks for the update!
For the first point did you see any need to add the escape quotes to the arguments? If it is working for you without them then I guess it is ok. For the breaking change, as you said it will make the API a bit confusing. So we can add this as a minor breaking change in the next FAKE minor release.

Also, could you please link this issue #2563 to the PR so that when it is merged the issue will be closed automatically.
Thanks

[lucasteles]

@yazeedobaid yeah, it worked

Also, could you please link this issue #2563 to the PR so that when it is merged the issue will be closed automatically.
Thanks

Done!

[yazeedobaid]

Thanks

[yazeedobaid]

Thanks

[yazeedobaid]

Thanks