Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get by packageid and an api to search by title #2585

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions src/app/Fake.DotNet.NuGet/NuGet.fs
Original file line number Diff line number Diff line change
Expand Up @@ -803,8 +803,14 @@ let extractFeedPackageFromJson (data : JObject) isLatestVersion =
Title = data.["title"].ToString()
}

/// Gets a Package information from NuGet feed by package id.
/// ## Parameters
///
/// - `repoUrl` - Query endpoint of NuGet search service
/// - `packageName` - The package to get
/// - `version` - The specific version to get
let getPackage (repoUrl:string) (packageName:string) (version:string) =
let url : string = repoUrl.TrimEnd('/') + "?q=title:" + packageName + "&take=1"
let url : string = repoUrl.TrimEnd('/') + "?q=packageid:" + packageName + "&take=1"
let resp = webClient.DownloadString(url)
let json = JObject.Parse resp
let data = (json.["data"] :?> JArray).[0] :?> JObject
Expand All @@ -821,14 +827,31 @@ let getPackage (repoUrl:string) (packageName:string) (version:string) =
data.["version"] <- JValue version
extractFeedPackageFromJson data isLatest


/// Gets the latest published package from NuGet feed by package id.
/// ## Parameters
///
/// - `repoUrl` - Query endpoint of NuGet search service
/// - `packageName` - The package to get
let getLatestPackage (repoUrl:string) packageName =
let url : string = repoUrl.TrimEnd('/') + "?q=title:" + packageName + "&take=1"
let url : string = repoUrl.TrimEnd('/') + "?q=packageid:" + packageName + "&take=1"
let resp = webClient.DownloadString(url)
let json = JObject.Parse resp
let data = (json.["data"] :?> JArray).[0] :?> JObject
extractFeedPackageFromJson data true

/// Search NuGet query endpoint for packages macthing given name by title
/// ## Parameters
///
/// - `repoUrl` - Query endpoint of NuGet search service
/// - `packageName` - The package to search for
let searchByTitle (repoUrl:string) (packageName:string) =
let url : string = repoUrl.TrimEnd('/') + "?q=title:" + packageName
let resp = webClient.DownloadString(url)
let json = JObject.Parse resp
let data = (json.["data"] :?> JArray).ToObject<List<JObject>>()
data
|> List.map(fun datum -> extractFeedPackageFromJson datum false)

/// [omit]
let downloadPackage targetDir (package : NuSpecPackage) =
Directory.ensure targetDir
Expand Down
15 changes: 15 additions & 0 deletions src/test/Fake.Core.UnitTests/Fake.DotNet.NuGet.fs
Original file line number Diff line number Diff line change
Expand Up @@ -96,5 +96,20 @@ let tests =
Expect.isNotEmpty package.ProjectUrl "ProjectUrl filled"
Expect.isNotEmpty package.LicenseUrl "LicenseUrl filled"
Expect.equal package.Title "FAKE" "Title filled"

testCase "Search by title returns results for matching packages by provided title" <| fun _ ->
let packages: NuGet.NugetPackageInfo list = NuGet.searchByTitle (NuGet.getRepoUrl()) "FAKE"
Expect.isGreaterThanOrEqual packages.Length 1 "Expected result has at least one element"
Expect.equal packages.[0].Id "FAKE" "Id filled"
Expect.isNotEmpty packages.[0].Version "Version filled"
Expect.isNotEmpty packages.[0].Description "Description filled"
Expect.isNotEmpty packages.[0].Summary "Id filled"
Expect.isFalse packages.[0].IsLatestVersion "IsLatestVersion filled"
Expect.isNotEmpty packages.[0].Authors "Authors filled"
Expect.isNotEmpty packages.[0].Owners "Owners filled"
Expect.isNotEmpty packages.[0].Tags "Tags filled"
Expect.isNotEmpty packages.[0].ProjectUrl "ProjectUrl filled"
Expect.isNotEmpty packages.[0].LicenseUrl "LicenseUrl filled"
Expect.equal packages.[0].Title "FAKE" "Title filled"
]