Converts Calls With Parameters to &optional instead of &rest
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing large numbers of arguments within a `&rest` variable is not very portable Common Lisp because of [call-arguments-limit](http://www.lispworks.com/documentation/HyperSpec/Body/v_call_a.htm). For performance reasons, users may want many bind parameters to take advantage of so-called extended inserts, e.g.: `INSERT INTO tbl_name (a,b,c) VALUES(?,?,?),(?,?,?),(?,?,?),(?,?,?),...` When this is the case, cl-dbi is artificially coupling how many `&rest` parameters can be passed with how many extended inserts a DB can support thus potentially artificially limiting an application's performance. Further, it becomes more difficult to write portable code because of this implementation detail. fixes fukamachi#60
|
Please note: I have not run the tests locally. My local |
fukamachi
added a commit
to fukamachi/datafly
that referenced
this pull request
Mar 13, 2020
fukamachi
added a commit
to fukamachi/mito
that referenced
this pull request
Mar 13, 2020
fukamachi
added a commit
to fukamachi/integral
that referenced
this pull request
Mar 13, 2020
fukamachi
added a commit
to fukamachi/crane
that referenced
this pull request
Mar 13, 2020
`dbi:execute` now takes the parameters as a list. refs fukamachi/cl-dbi#61
fukamachi
added a commit
to fukamachi/dbd-oracle
that referenced
this pull request
Mar 13, 2020
`dbi:execute` now takes the parameters as a list. refs fukamachi/cl-dbi#61
fukamachi
added a commit
to fukamachi/cl-dbi-connection-pool
that referenced
this pull request
Mar 13, 2020
`dbi:execute` now takes the parameters as a list. refs fukamachi/cl-dbi#61
fukamachi
added a commit
to fukamachi/cl-batis
that referenced
this pull request
Mar 13, 2020
`dbi:execute` now takes the parameters as a list. refs fukamachi/cl-dbi#61
vindarel
added a commit
to vindarel/cl-dbi
that referenced
this pull request
Apr 10, 2020
vindarel
added a commit
to vindarel/cl-dbi
that referenced
this pull request
Apr 10, 2020
mohammad-matini
added a commit
to kayisoft/kayishort
that referenced
this pull request
Oct 5, 2021
dbi:execute now takes its parameters as a list, see: fukamachi/cl-dbi#61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing large numbers of arguments within a
&restvariable is notvery portable Common Lisp because of
call-arguments-limit.
For performance reasons, users may want many bind parameters to take
advantage of so-called extended inserts, e.g.:
INSERT INTO tbl_name (a,b,c) VALUES(?,?,?),(?,?,?),(?,?,?),(?,?,?),...When this is the case, cl-dbi is artificially coupling how many
&restparameters can be passed with how many extended inserts a DB can
support thus potentially artificially limiting an application's
performance. Further, it becomes more difficult to write portable code
because of this implementation detail.
fixes #60