Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh token missing property #128

Closed
markosimulak opened this issue Nov 3, 2021 · 3 comments
Closed

Refresh token missing property #128

markosimulak opened this issue Nov 3, 2021 · 3 comments

Comments

@markosimulak
Copy link
Contributor

markosimulak commented Nov 3, 2021 •
edited
Loading

Hi :)

Bug description

While working with refresh token, I've found out that in GetPrincipalFromExpiredToken() function, property ValidateLifetime should be set to false when creating TokenValidationParameters instance.

How to fix

  1. Go to https://github.com/fullstackhero/dotnet-webapi-boilerplate/blob/d907cacdb6534fe1053ced6da0fc2a5c869df013/src/Infrastructure/Identity/Services/TokenService.cs#L169
  2. Extend tokenValidationParameters variable with ValidateLifetime = false
@iammukeshm
Copy link
Member

Could you please make the changes and raise a pull request for it? I will merge it.

@iammukeshm
Copy link
Member

Please pull the latest code and commit your changes. Thanks

@markosimulak
Copy link
Contributor Author

Sure, no problem.

markosimulak added a commit to markosimulak/dotnet-webapi-boilerplate that referenced this issue Nov 4, 2021
@markosimulak
Fix for fullstackhero#128
98b1457
iammukeshm added a commit that referenced this issue Nov 5, 2021
@iammukeshm
Merge pull request #130 from markosimulak/main
97b3c86 
Fix for #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markosimulak @iammukeshm