-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Generic Repository Code #250
Refactor Generic Repository Code #250
Conversation
@@ -10,9 +10,13 @@ | |||
<PackageReference Include="MediatR.Extensions.Microsoft.DependencyInjection" Version="9.0.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="6.0.0" /> | |||
<PackageReference Include="Microsoft.Extensions.Localization" Version="6.0.0" /> | |||
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="6.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole point of Repository Pattern is to remove the Dependency with EFCore or any other ORMs in the Application / Core layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the dependency has been removed.
Thanks! Could you please add comments over each of the interface method definitions of IRepositoryAsync ? For documentation purposes. You can do it as a new PR. Something like
|
Sure |
More consistent generic repository approach
Made use of IIncludeableQueryable for typed Includes
Made use of IOrderedQueryable for typed OrderBy
Made provision for returning projected entities