Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #202

Closed
wants to merge 2 commits into from
Closed

Update all dependencies #202

wants to merge 2 commits into from

Conversation

HZSamir
Copy link

@HZSamir HZSamir commented May 22, 2017

No description provided.

@arelaxend
Copy link

My first try gives an error. It has failed on iOS "Possible unhandled promise rejection".

@arelaxend
Copy link

There is an error in the last commit. Must replace "icon: () =>" to "icon: (props) =>" in ColorView.js

@HZSamir
Copy link
Author

HZSamir commented May 30, 2017

@arelaxend Strange, I hadn't noticed that. Must come from the fact that I tested it only on Android.
Thanks for pointing it out.

@arelaxend
Copy link

👍 Good job btw.

@arelaxend
Copy link

What is going on with the project ? Is it still going on ?

@HZSamir
Copy link
Author

HZSamir commented May 30, 2017

There haven't been updates since more than a month. I wouldn't want this repo to wither and die as it is the best starter boilerplate out there for RN.

@FruitieX
Copy link
Contributor

FruitieX commented Jun 1, 2017

Thanks for the pull request. We have been very busy lately, but I will attempt to take the ball on maintaining this project in about 2 weeks from now. I agree that this is still a useful RN starter kit, and hopefully we can make it even better soon. :)

@FruitieX
Copy link
Contributor

The react-native upgrade breaks testing with Enzyme. Reason for this is that react-native depends on React 16 from v0.43 and up, which Enzyme does not yet support as React 16 is still in alpha. Might have to wait until Enzyme gains support for React 16.

In the mean-time, I'm maintaining a branch over at upgrade-dependencies with the latest versions of packages (and thus broken Enzyme tests). It contains the changes from this PR, so let's continue the discussion over at #209

@FruitieX FruitieX closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants