.github/workflows: Make sure to run all Go 1.19 tests #3448
Conversation
This makes sure to enable all tests to run using Go 1.19. Apparently they are checking for only Go 1.17 which is a not so elegant solution. This is a quick-fix to make sure that everything runs as expected.
|
Looks like the correct fix is actually to put 1.17 back for the web build/test |
GopherJs is still pending 1.19 suppport which itself is on hold until 1.18 Generic support 1.18 support (without generics) was released in v1.18.0-beta1 |
|
Yeah. I'll get this sorted later today |
| @@ -9,7 +9,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| go-version: [1.14, 1.19] | |||
| go-version: [1.14, 1.17] | |||
There was a problem hiding this comment.
Can't we have 1.14, 1.17 and 1.19? As the gopherjs test is only enable for 1.17, that would work, no?
There was a problem hiding this comment.
That is adding a lot of time to the compiling.
Really I think we should use 19 for most, and add another test run for the web build which can use 1.17
There was a problem hiding this comment.
We had more than two Go versions earlier but it gets very slow in the long run. I prefer to keep it as it is
There was a problem hiding this comment.
Yeah, I agree with @andydotxyz. That seems like a good idea. Will add that to my list
There was a problem hiding this comment.
You are also free to tackle that @Bluebugs if you are interested :)
|
|
||
| - name: Build WebAssembly binary | ||
| env: | ||
| GOOS: js | ||
| GOARCH: wasm | ||
| working-directory: cmd/fyne_demo | ||
| run: go build | ||
| if: ${{ matrix.go-version == '1.19' }} | ||
| if: ${{ matrix.go-version == '1.17' }} |
There was a problem hiding this comment.
I would really prefer if wasm was checked against 1.19 as the idea is that wasm come out of latest go and that work, while gopherjs require an older go as backup solution for problematic browser.
There was a problem hiding this comment.
As stated in my previous comment, I prefer to only have two Go versions at the time. We will slow down our CI times a lot otherwise. Lets just keep this PR simple and fix the issue to make it behave as before
|
A drive-by comment on behalf of the GopherJS project. Go 1.19 support is on hold merely because I (personally) don't have time to work on both Go 1.19 support and generics at the same time, and I feel like working on generics is more important. However, if folks are interested in making Go 1.19 support appearing sooner, this would be a welcome contribution :) I even wrote a guide to make this easier for the newer contributors. Cheers! |
|
Great pointer @nevkontakte and thanks so much for the hard work, we appreciate it. |
This makes sure to enable all tests to run using Go 1.19. Apparently they are checking for only Go 1.17 which is a not so elegant solution. This is a quick-fix to make sure that everything runs as expected.
Description:
This makes sure to enable all tests to run using Go 1.19. Apparently they are checking for only Go 1.17 which is a not so elegant solution. This is a quick-fix to make sure that everything runs as expected.
Checklist: