Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial sign & marshal binary of partial signed transaction #99

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Support partial sign & marshal binary of partial signed transaction #99

merged 2 commits into from
Sep 13, 2022

Conversation

0ximalice
Copy link
Contributor

@0ximalice 0ximalice commented Sep 12, 2022

Hi,

I recently added some features to my forked repo and need to contribute back to the origin repo.
All features including

  • feat: added PartialSign along with Sign transaction
  • fix: new signed signatures are only added on success to prevent unwanted signatures stacking on failed cases (https://github.com/imalic3/solana-go/blob/feature/partial_sign/transaction.go#L397)
  • remove a signature verification checked while marshal binary which will be available to marshal partial-signed transaction.
  • tests: added partial sign and sign tests

Thanks for your awesome work

@0ximalice 0ximalice changed the title Support partial sign & marshal partial signed transaction Support partial sign & marshal binary of partial signed transaction Sep 12, 2022
@gagliardetto gagliardetto merged commit 00d84da into gagliardetto:main Sep 13, 2022
@gagliardetto
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants