Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cached reference using all_fasta.loc for snippy #2575

Closed
wants to merge 4 commits into from
Closed

add cached reference using all_fasta.loc for snippy #2575

wants to merge 4 commits into from

Conversation

thanhleviet
Copy link
Contributor

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

bernt-matthias
bernt-matthias reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thanhleviet

tools/snippy/snippy.xml Outdated Show resolved Hide resolved
tools/snippy/snippy.xml Show resolved Hide resolved
tools/snippy/snippy.xml Outdated Show resolved Hide resolved
tools/snippy/snippy.xml Show resolved Hide resolved
tools/snippy/snippy.xml Show resolved Hide resolved
bgruening
bgruening reviewed Sep 9, 2019
View reviewed changes
tools/snippy/snippy.xml
</test>

<test> <!-- test 4 - reference source as cached -->
<param name="reference_source|reference_source_selector" value="cached"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use the more explicit <conditional> syntax in test as well?

bgruening
bgruening reviewed Sep 9, 2019
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase both tool versions. And it would be nice if you can use the more explicit conditional syntax for tests as well.

Thanks @thanhleviet!

Slugger70 added a commit to Slugger70/tools-iuc that referenced this pull request Sep 11, 2019
@Slugger70
Merged thanhleviet's changes from PR galaxyproject#2575 here
ced4edf
@Slugger70
Copy link
Contributor

I have fixed reviewer comments and merged this PR with PR #2588

@Slugger70
Copy link
Contributor

Slugger70 commented Sep 11, 2019 •
edited
Loading

@bgruening Can this PR be closed now that it has been merged with another?

@Slugger70 Slugger70 mentioned this pull request Sep 11, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

@bernt-matthias bernt-matthias bernt-matthias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thanhleviet @Slugger70 @bgruening @bernt-matthias