Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Check file sizes only for changed files #4291

Merged
merged 2 commits into from
Dec 14, 2021
Merged

CI: Check file sizes only for changed files #4291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67d52e8
check file sizes only for changed files
bernt-matthias Oct 15, 2021
b2fd6bc
Update .github/workflows/pr.yaml
bernt-matthias Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ jobs:
tool-list: ${{ steps.discover.outputs.tool-list }}
chunk-count: ${{ steps.discover.outputs.chunk-count }}
chunk-list: ${{ steps.discover.outputs.chunk-list }}
commit-range: ${{ steps.discover.outputs.commit-range }}
strategy:
matrix:
python-version: ['3.7']
Expand Down Expand Up @@ -226,14 +227,10 @@ jobs:
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- name: Save repositories to file
run: echo '${{ needs.setup.outputs.repository-list }}' > repository_list.txt
fetch-depth: 0
- name: Check file sizes
run: |
while read repo; do
find "$repo" -size +${{ env.MAX_FILE_SIZE }}
done < repository_list.txt > file_size_report.txt
find $(git diff --name-only ${{ needs.setup.outputs.commit-range }}) -type f -size +${{ env.MAX_FILE_SIZE }} > file_size_report.txt
if [[ -s file_size_report.txt ]]; then
echo "Files larger than ${{ env.MAX_FILE_SIZE }} found"
cat file_size_report.txt
Expand Down Expand Up @@ -384,7 +381,7 @@ jobs:

determine-success:
name: Check workflow success
needs: [setup, lint, flake8, lintr, combine_outputs]
needs: [setup, lint, flake8, lintr, file_sizes, combine_outputs]
if: ${{ always() && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/main' }}
runs-on: ubuntu-latest
steps:
Expand All @@ -397,6 +394,9 @@ jobs:
- name: Indicate R script lint status
if: ${{ needs.lintr.result != 'success' && needs.lintr.result != 'skipped' }}
run: exit 1
- name: Indicate file size check status
if: ${{ needs.file_sizes.result != 'success' && needs.file_sizes.result != 'skipped' }}
run: exit 1
- name: Check tool test status
if: ${{ needs.combine_outputs.result != 'success' && needs.combine_outputs.result != 'skipped' }}
run: exit 1