Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS quit shortcut is unexpected #141

Closed
6 tasks done
thibault-ml opened this issue May 1, 2020 · 3 comments · Fixed by #142
Closed
6 tasks done

macOS quit shortcut is unexpected #141

thibault-ml opened this issue May 1, 2020 · 3 comments · Fixed by #142
Labels
bug Something isn't working

Comments

@thibault-ml
Copy link
Contributor

Prerequisites

If the following boxes are not ALL checked, your issue is likely to be closed.

  • Using yarn
  • Using node 10.x
  • Using an up-to-date master branch
  • Using latest version of devtools. See wiki for howto update
  • For issue in production release, devtools output of DEBUG_PROD=true yarn build && yarn start
  • Tried solutions mentioned in #400

Describe the bug
On macOS, the app does not quit when using CMD+Q which is the "Quit" shortcut on macOS.

Expected behaviour
The app uses the macOS shortcut: CMD+Q.

Current Behavior
The app currently requires ALT+CMD+Q, which is an unusual and unexpected shortcut for macOS users.

Steps to Reproduce (for bugs)

  1. Launch the app
  2. Press CMD+Q
  3. App does not quit

Your Environment
Include as many relevant details about the environment you experienced the bug in

  • macOS 10.15.4
  • OpenMTP 2.4.1 (downloaded from release page)

Screenshots
Screenshot 2020-05-01 at 17 38 30
@thibault-ml thibault-ml added the bug Something isn't working label May 1, 2020
@thibault-ml thibault-ml changed the title macOS quit shortcut is wrong macOS quit shortcut is unexpected May 1, 2020
@thibault-ml thibault-ml mentioned this issue May 1, 2020
Merged
@ganeshrvel
Copy link
Owner

Replied: #142 (comment)

ganeshrvel added a commit that referenced this issue Jun 15, 2020
@ganeshrvel
Merge pull request #142 from thibault-ml/patch-1
5d93d73 
#141 Use standard macOS quit shortcut
@ganeshrvel ganeshrvel reopened this Jun 15, 2020
@ganeshrvel
Copy link
Owner

Fixed the issue.
https://github.com/ganeshrvel/openmtp/releases/tag/v2.4.4

@thibault-ml
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#141 Use standard macOS quit shortcut thibault-ml/openmtp
2 participants
@thibault-ml @ganeshrvel