#141 Use standard macOS quit shortcut

[thibault-ml]

On macOS, the shortcut to quit apps is CMD+Q. CMD+ALT+Q is actually unexpected to macOS users.

Fixes #141

[tie]

Great! I’d love to see this merged.

[thibault-ml]

@ganeshrvel Let me know if you need anything else :-).

[ganeshrvel]

@thibault-ml thanks for the PR. Currently I am caught up with a lot of things, hopefully very soon I will release this feature.

I deliberately changed the macOS quit shortcut to Command+Alt+Q because we have command+1 and command+a shortcuts and these keys are very close to 'q'.
I am thinking of implementing manual keymap overrides.

[thibault-ml]

I deliberately changed the macOS quit shortcut to Command+Alt+Q because we have command+1 and command+a shortcuts and these keys are very close to 'q'.

I understand the intention, and while I agree the closeness is unfortunate, it is a fact that cmd+a and cmd+q are system-wide shortcuts that all macOS users know and use, because every single app on macOS, whether from Apple or 3rd parties, use those very same shortcuts for the same things.

Having just the one odd app (OpenMTP) use a different shortcut means it will not be user friendly, and risk confusing the intended audience (macOS users) when trying to close the app.

[thibault-ml]

@ganeshrvel By the way, users can already change shortcuts on a per-app basis should they wish to, using System Preferences > Keyboard > Shortcut, meaning you wouldn't have to do it yourself :D. I do think it's important to keep the expected system-wide shortcut by default, however.

[tie]

I agree with @thibault-ml.

Many macOS applications, including Mail.app, Safari.app, Terminal.app, and other built in apps, have Command+1 (e.g. for switching between tabs) and Command+A (e.g. for selecting all text) shortcuts. Changing the default quit shortcut makes UX inconsistent and interrupts the workflow.

I think the best way would be to ask for confirmation if there is an ongoing transfer. That’s also what Transmission.app does when seeding torrents.

[Shahor]

As a macOS user relying heavily on keyboard shortcuts, the override of the system default shortcut is quite painful.

Please consider not overriding the system defaults that 100% of users know and use.

[ganeshrvel]

merged