Various ipmi improvements #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tabaer
commented
Aug 2, 2016
tabaer
commented
- Make ipmi_ip, username, password, and level optional (e.g. in case host has ipmi kernel driver loaded)
- Add support for using sudo to invoke ipmitool
- try to use common sensor names between vendors' IPMI implementations where possible.
* Add support for using sudo to invoke ipmitool * try to use common sensor names between vendors' IPMI implementations where possible.
that we're not constantly adding or removing the metric prefix.
way ipmitool can succeed (i.e. if ipmi_ip isn't set and there is no ipmi device file available).
…n the first pass * make the timeout on ipmitool configurable with a default value of 15 seconds, as 3 seconds is too short for some ipmi implementations (notably HP's)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.