Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect on login Closes #1031 #1033

Merged
merged 3 commits into from
Aug 14, 2021

Conversation

JasirZaeem
Copy link
Member

Closes #1031

Changes

Add next query param to /login page

Links to login page can now be of the form /login?next=further-path if the next param is present in the query, the user will be redirected to /further-path on successful login.

Fix redirection from /review/[lesson]

Logged out users who visit a review page will be redirected to the login page with the correct next parameter so that they are redirected back to this page on successful login.

@vercel
Copy link

vercel bot commented Aug 14, 2021

@JasirZaeem is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel.

@garageScript first needs to authorize it.

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #1033 (cc5893c) into master (7a6a2e4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          123       123           
  Lines         1994      1995    +1     
  Branches       484       485    +1     
=========================================
+ Hits          1994      1995    +1     
Impacted Files Coverage Δ
pages/login.tsx 100.00% <100.00%> (ø)
pages/review/[lesson].tsx 100.00% <100.00%> (ø)

@vercel
Copy link

vercel bot commented Aug 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/8p812ze6whhM7NXZpCuHpR7aVYvW
✅ Preview: https://c0d3-app-git-fork-jasirzaeem-redirect-on-login-c0d3.vercel.app

@ggwadera ggwadera merged commit f1d7996 into garageScript:master Aug 14, 2021
@JasirZaeem JasirZaeem deleted the redirect-on-login branch August 14, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect back to review page after redirection to login
3 participants