Changes tests comparing paths to be cross platform Closes #1076 #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasirZaeem is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 2168 2168
Branches 506 506
=========================================
Hits 2168 2168 |
tomrule007
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1076
As described in 1076, tests comparing file paths using simple string equality/matching don't work across platforms as different platforms can use different characters as file separators. Some of these tests were fixed in #1078
#1078 (comment) these two checks are fixed in this PR.
Instead of comparing with
filePath,path.join(process.cwd(), filePath)is used to evaluate the correct path for the platform and then compared.