-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/try catch unknown #1162
Refactor/try catch unknown #1162
Conversation
@tomrule007 is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/7azBQwd2VuVTVFHSz8rR4GAK13Zh |
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 144 144
Lines 2419 2397 -22
Branches 618 614 -4
=========================================
- Hits 2419 2397 -22
|
What
Clean up some technical debt adding better types to try..catch errors and remove unnecessary captures that just rethrow.
Why
So we can update to TypeScript 4.4+ without adding more technical debt by just casting errors back to
any
.*TS now types errors as
unknown
instead of the old defaultany
How
ValidationError
fromyup
)*The Apollo Log Plugin already logs all resolver errors)