Improved Discord notifications #1826
Conversation
getDiscordMessageUserIdString returns "<@[user.discordId]>" which mentions that discord user or "**[user.username]**" which shows user's c0d3 username in bold if their discord id is unavailable.
|
@JasirZaeem is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel. @garageScript first needs to authorize it. |
Update mock data to attempt to fix unexpected rejection in describe("Add comment resolver", ...)
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 161 163 +2
Lines 2751 2793 +42
Branches 732 745 +13
=========================================
+ Hits 2751 2793 +42
|
| @@ -0,0 +1,178 @@ | |||
| /** | |||
There was a problem hiding this comment.
NIT: space between the test cases and variables would make the code a little bit easier to go through.
| const { author, submission } = comment | ||
|
|
||
| if (author.id !== submission.user.id && submission.user.discordId) { | ||
| const notificationEmbed: MessageEmbedOptions = { |
There was a problem hiding this comment.
Is it necessary to explicitly give it a type? TypeScript is capable of inferring its type and comparing the object's properties with sendDirectMessage first parameter type.
There was a problem hiding this comment.
Yeah ts will figure out if the type is sufficient when this object is passed to the function, but I have explicitly typed the object literal as MessageEmbedOptions to help with autocomplete and ides when reading/modifying the variable where it is declared.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
helpers/updateSubmission.ts
Outdated
| if (user.discordId && reviewer) { | ||
| const reviewerString = getDiscordMessageUserIdString(reviewer) | ||
| const reviewNotificationEmbed: MessageEmbedOptions = { | ||
| color: '#5440d8', |
There was a problem hiding this comment.
should this also be a constant?
Followup to #949
Use discord ids of connected users to add and improve notifications
On challenge submission
On lesson completion
On receiving a star
On a comment on user's submission
Sent dm
On acceptance/rejection of user's submission
Sent dm
The title of the direct message is the reviewer's or commenter's name on c0d3.
The message either mentions the c0d3 user or discord username/nickname if their discord id is available, this let's other's easily know them on discord. The mention can also be clicked on to dm users.