Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary forgot-password full page load #2247

Merged
merged 2 commits into from
Sep 3, 2022
Merged

Remove unnecessary forgot-password full page load #2247

merged 2 commits into from
Sep 3, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Sep 1, 2022

Closes #2250

Before this change, when you got an error on the forgot-password page then clicked "Go Back", it would do a full page reload.
This change removes that full page load, so now it just goes back instantly when you click "Go Back".

How to test:

  • Go to /forgotpassword.
  • Type in a username that doesn't exist and hit ENTER so it causes an error to happen.
  • Click the "Go Back" button and notice there is no full page reload.

@vercel
Copy link

vercel bot commented Sep 1, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #2247 (97339b0) into master (7af5b27) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines         2952      2954    +2     
  Branches       796       796           
=========================================
+ Hits          2952      2954    +2     
Impacted Files Coverage Δ
pages/forgotpassword.tsx 100.00% <100.00%> (ø)

@vercel
Copy link

vercel bot commented Sep 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 0:31AM (UTC)

@flacial
Copy link
Member

flacial commented Sep 2, 2022

May you create and link an issue to it (Closes #1234)?

@bryanjenningz
Copy link
Collaborator Author

May you create and link an issue to it (Closes #1234)?

Done

@bryanjenningz bryanjenningz merged commit a0c41a7 into garageScript:master Sep 3, 2022
@bryanjenningz bryanjenningz deleted the remove-unnecessary-forgotpassword-full-page-load branch September 3, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary forgot-password full page load
3 participants