closes #438, #439 - return name in getLessonMentors resolver, create validateLessonId function #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#438
In our designs, the list of
lesson mentors
has both the mentor's username and name. Currently thegetLessonMentors
resolver only returns a mentor's username, and so it needs to be updated to also return the mentor's name.#439
The
lessonExists
function is only being used to see if an error message should be thrown or not. Since this logic ofcheck if lesson exists -> throw error
is repetitive in the codebase, a function should handle this logic.This PR will:
getLessonMentors
to also return a mentor's namelessonExists
and createvalidateLessonId
functionvalidateLessonId
instead oflessonExists
function