-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #442 - return starsGiven inside session resolver, create validation folder #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolver, create validateStudentId, create validation folder
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/mc5tar27j |
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 88 +1
Lines 1184 1193 +9
Branches 254 255 +1
=========================================
+ Hits 1184 1193 +9
|
…omises being dealt with..
ggwadera
approved these changes
Dec 14, 2020
…veLessonStar`
ggwadera
approved these changes
Dec 14, 2020
…e a starsGiven field for UserLesson type
…t with styling of testing file
ggwadera
approved these changes
Dec 18, 2020
songz
approved these changes
Dec 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
closes #442
The upcoming
giveStarCard
needs this in order to load aStar already given to <username>
modal if a person has already given a star.This PR will:
session
resolver, update so it also returnsstarsGiven
UserLesson type
intypedefs
validateStudentId
file insidehelpers/validation
foldersetStar
file tostarsController
, and place insidehelpers/controllers
folderQuestions you may ask
There are other validation files that this PR did not move into the
validation
folder. Why?This PR is big enough. Another PR should be made to finish moving the validation files into the validation folder. You can see the large number of files that need to be changed in the image below
The
validateStudentId
function is only being used in thestarsController
file and nowhere else, so why make a separate file to export this function?student to be logged in