[Feature] Send chat notification on submission review #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/f0qqwg6mh |
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 1157 1184 +27
Branches 252 254 +2
=========================================
+ Hits 1157 1184 +27
|
anthonykhoa
approved these changes
Dec 17, 2020
songz
reviewed
Dec 17, 2020
helpers/mattermost.ts
Outdated
| async (id: string): Promise<UserInfo> => { | ||
| try { | ||
| const response = await fetch(`${chatServiceUrl}/users/${id}`, { headers }) | ||
| return await response.json() |
There was a problem hiding this comment.
you could do just return response.json() right?
songz
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444
This PR will:
SubmissionStatusenum to help avoid using strings for submission status;sendChatNotificationfunction inupdateSubmission, to send a notification to the user when their submission has been accepted or rejected, including the review comment;