Closes #423 - Mentions c0d3.com being free. Rewords footer. #460
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/8krfnq5w5 |
|
Hey there, nice work fixing this. Thanks 🙂 For the failed tests, only the snapshot tests failed. It compares the rendered DOM to a pre-rendered file, since you modified the text it caused them to fail. To fix it just run |
components/LandingPage.tsx
Outdated
| <p | ||
| className="mt-3 font-weight-light" | ||
| style={{ lineHeight: 1.5, fontSize: '1.5rem' }} | ||
| > | ||
| Start your journey to being a full stack software engineer | ||
| Become a full stack software engineer - 100% Free |
There was a problem hiding this comment.
I think adding an exclamation mark at the end will make this message sound better.
Become a full stack software engineer - 100% Free!
Adding the exclamation mark will give the message a more enthusiastic tone, while also creating more emphasis that c0d3 is 100% free.
There was a problem hiding this comment.
I agree, I like the enthusiasm!
|
You gotta commit the updated snapshots too! Otherwise the build system will use the current ones. |
|
I see now. Thanks for bearing with me! |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 90 91 +1
Lines 1208 1220 +12
Branches 258 258
=========================================
+ Hits 1208 1220 +12
|
No worries, thank you for your contribution! Let me see if the contributions bot still works haha. @all-contributors please add @pmulard for code |
|
I've put up a pull request to add @pmulard! 🎉 |
|
Sweet! First contribution is in the books! Here's to many more |
The original mentions starting 3 times in this little footer section, so I figured this would be a good spot to rework the phrases and add in c0d3.com being free. Below are before and after screenshots.
edit: I see now the CI/build failed because I forgot to run yarn auto fix on the test suits before committing the changes. Not sure exactly how to handle this... this is my first pull request :)