closes #468 - migrate to apollo client 3 #475
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/c0d3/c0d3-app/hvl50g0y6 |
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 94 94
Lines 1271 1272 +1
Branches 266 265 -1
=========================================
+ Hits 1271 1272 +1
|
| //create a new Challenges array with user submission data integrated and sorted | ||
| const challengesWithSubmissionData: ChallengeSubmissionData[] = challenges | ||
| const challengesWithSubmissionData: ChallengeSubmissionData[] = challengesCopy |
There was a problem hiding this comment.
I am surprised why this didn't caused any problems before. I created a copy of challenges to use in map-sort, otherwise it was causing type errors.
pages/_app.tsx
Outdated
| import withApollo from '../helpers/withApollo' | ||
| import { ApolloClient, NormalizedCacheObject } from 'apollo-boost' | ||
| import { ApolloClient, NormalizedCacheObject } from '@apollo/client' |
There was a problem hiding this comment.
can we do just 1 import for ApolloProvider, ApolloClient, and NormalizedCacheObject?
|
I accidentally submitted some commits as GH Pages Bot, so if anyone decides to merge this pr please squash it into Ulisseus commit and not to the bot ones. |
closes #468
In newer version many apollo packages were merged into one. This pr is mostly about using proper imports.
Locally I tested creating new users, submitting and reviewing challenges.