Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #476 - Notify chatroom when someone receives a star #477

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

anthonykhoa
Copy link
Collaborator

closes #476

Version 1 of c0d3 had it such that whenever someone received a star for a lesson module, a notification would appear in that lesson module's chatroom(for example js0 chatroom)

Currently, our setStar resolver(which handles making a request to the database to give a user a star) does not notify the chatroom

This PR will

  • Update the setStar graphql resolver to notify chatroom when star has been received by someone
  • Update corresponding testing file

@vercel
Copy link

vercel bot commented Jan 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/ha0ix763q
✅ Preview: https://c0d3-app-git-fork-anthonykhoa-starmatters.c0d3.vercel.app

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #477 (60a1fc4) into master (57aa00e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #477   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines         1271      1275    +4     
  Branches       266       266           
=========================================
+ Hits          1271      1275    +4     
Impacted Files Coverage Δ
helpers/controllers/starsController.ts 100.00% <100.00%> (ø)

@ggwadera ggwadera merged commit f1f35af into garageScript:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chatroom needs to be notified when someone receives a star
3 participants