Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lesson pass check #967

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

JasirZaeem
Copy link
Member

fixes #966

Fixes incorrect passed lesson computation by counting only 1 submission per challengeId in a lesson by using a distinct clause.

The submissions.count query has been replaced by a findMany because count does not support the distinct clause. Only challengeId for each submission is fetched to fetch minimal extra data from the the db

@vercel
Copy link

vercel bot commented Jul 20, 2021

@JasirZaeem is attempting to deploy a commit to a Personal Account owned by @garageScript on Vercel.

@garageScript first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/c0d3/c0d3-app/36fw5hwnX1jEGtejKfTaqRGKpf6u
✅ Preview: https://c0d3-app-git-fork-jasirzaeem-fix-lesson-pass-check-c0d3.vercel.app

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #967 (aeac976) into master (ea4e07e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #967   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          122       122           
  Lines         2020      2020           
  Branches       492       492           
=========================================
  Hits          2020      2020           
Impacted Files Coverage Δ
helpers/updateSubmission.ts 100.00% <100.00%> (ø)

@JasirZaeem JasirZaeem merged commit 8d0230f into garageScript:master Jul 20, 2021
@JasirZaeem JasirZaeem deleted the fix-lesson-pass-check branch July 20, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incorrect lesson passed computation
2 participants