Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor etcd library to v3.4.13 #269

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Revendor etcd library to v3.4.13 #269

merged 1 commit into from
Oct 21, 2020

Conversation

shreyas-s-rao
Copy link
Collaborator

Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com

What this PR does / why we need it:
This PR revendors etcd library to v3.4.13, and changes import paths to go.etcd.io/etcd for etcd and go.etcd.io/bbolt for bbolt. Refer etcd-io/etcd#9965.

Which issue(s) this PR fixes:
Fixes #49

Special notes for your reviewer:

Release note:

Revendor etcd library to v3.4.13 and change import paths to `go.etcd.io/etcd` for etcd and `go.etcd.io/bbolt` for bbolt.

@shreyas-s-rao shreyas-s-rao added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related needs/review Needs review component/etcd-backup-restore ETCD Backup & Restore needs/lgtm Needs approval for merging labels Oct 6, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test-tm Has approval for running integration tests on TestMachinery labels Oct 6, 2020
@shreyas-s-rao shreyas-s-rao removed the reviewed/ok-to-test-tm Has approval for running integration tests on TestMachinery label Oct 6, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the needs/ok-to-test-tm Requires integration tests to be run on TestMachinery label Oct 6, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 6, 2020
@amshuman-kr amshuman-kr added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 7, 2020
@shreyas-s-rao
Revendor etcd library to v3.4.13
1eb05c9 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed needs/review Needs review labels Oct 14, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test-tm Has approval for running integration tests on TestMachinery needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test-tm Has approval for running integration tests on TestMachinery label Oct 14, 2020
@amshuman-kr amshuman-kr added this to the v0.11.0 milestone Oct 19, 2020
amshuman-kr
amshuman-kr approved these changes Oct 21, 2020
View reviewed changes
Copy link
Collaborator

@amshuman-kr amshuman-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shreyas-s-rao! I have tested the migration cases and they look good. LGTM

@amshuman-kr amshuman-kr merged commit 661bf24 into gardener:master Oct 21, 2020
@shreyas-s-rao shreyas-s-rao deleted the etcd-revendor branch October 23, 2020 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amshuman-kr amshuman-kr amshuman-kr approved these changes

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@swapnilgm swapnilgm Awaiting requested review from swapnilgm

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related component/etcd-backup-restore ETCD Backup & Restore needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test-tm Requires integration tests to be run on TestMachinery size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Update etcd imports and vendor to github.com/etcd-io/etcd
6 participants
@shreyas-s-rao @amshuman-kr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot