Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MCM migration method #2

Merged
merged 2 commits into from
Dec 18, 2020
Merged

Implement MCM migration method #2

merged 2 commits into from
Dec 18, 2020

Conversation

minchaow
Copy link
Contributor

What this PR does / why we need it:
This PR is to implement method GenerateMachineClassForMigration.
Which issue(s) this PR fixes:
Fixes #
None
Special notes for your reviewer:
None
Release note:

GenerateMachineClassForMigration is implemented.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 18, 2020
prashanth26
prashanth26 reviewed Dec 18, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these quick changes.
/lgtm just minor comments.

pkg/alicloud/apis/alicloud_provider_spec.go Outdated Show resolved Hide resolved
pkg/alicloud/apis/alicloud_provider_spec.go Outdated Show resolved Hide resolved
pkg/alicloud/migration.go Show resolved Hide resolved
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 18, 2020
@minchaow minchaow force-pushed the mcm-migrate branch 2 times, most recently from d472188 to 4ed5e1a Compare December 18, 2020 08:50
prashanth26
prashanth26 approved these changes Dec 18, 2020
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the changes.

@minchaow minchaow merged commit ab0c20f into master Dec 18, 2020
@minchaow minchaow deleted the mcm-migrate branch December 18, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minchaow @prashanth26 @gardener-robot