Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci:component:github.com/gardener/machine-controller-manager:v0.52.0->v0.53.0] #162

Merged
merged 6 commits into from
May 17, 2024
Merged

[ci:component:github.com/gardener/machine-controller-manager:v0.52.0->v0.53.0] #162

merged 6 commits into from
May 17, 2024

Conversation

gardener-robot-ci-2
Copy link
Contributor

@gardener-robot-ci-2 gardener-robot-ci-2 commented Apr 19, 2024 •
edited by rishabh-11
Loading

Which issue(s) this PR fixes:
Fixes #145

Release Notes:

Updated k8s dependencies to `v0.29.3`

Removed vendor directory

 New provider method Driver.InitializeMachine added for Post-Creation VM Instance Initialization steps.

Add `Ipv6AddressCount` and `Ipv6PrefixCount` to enable the assignment of an ipv6 address and an ipv6 prefix to instances.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 19, 2024
@gardener-robot gardener-robot added the needs/review Needs review label Apr 19, 2024
@gardener-robot
Copy link

@gardener-robot-ci-2 Thank you for your contribution.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Apr 19, 2024
@elankath elankath self-assigned this Apr 23, 2024
@elankath
Copy link
Contributor

This is WIP and in testing at the moment and will also incorporate #128

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 25, 2024
@elankath elankath removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2024
@elankath elankath added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 25, 2024
@axel7born
Copy link
Contributor

/lgtm

I checked that Ipv6AddressCount and Ipv6PrefixCount were added and an IPv6 address and an IPv6 prefix were assigned to the instance. To configure the machine class I have used gardener/gardener-extension-provider-aws#785 of the aws provider and the shoot has been setup with infrastructureConfig.dualStack.enabled=true.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 7, 2024
@elankath elankath added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2024
This was referenced May 17, 2024
Closed
Closed
rishabh-11
rishabh-11 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

rishabh-11
rishabh-11 requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change needed. Rest looks good.

pkg/aws/core.go Outdated Show resolved Hide resolved
@elankath @rishabh-11
Update pkg/aws/core.go
2f42660 
if `SourceDestCheck` is already disabled on instance then skip work

Co-authored-by: Rishabh Patel <66425093+rishabh-11@users.noreply.github.com>
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2024
rishabh-11
rishabh-11 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rishabh-11 rishabh-11 merged commit 1a25c04 into master May 17, 2024
7 checks passed
@rishabh-11 rishabh-11 deleted the ci-jbtijoipd branch May 17, 2024 06:08
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 17, 2024
@rishabh-11 rishabh-11 mentioned this pull request Jul 3, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adoption of Driver.InitializeMachine
7 participants
@gardener-robot-ci-2 @gardener-robot @elankath @axel7born @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-3