Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce noisy reconciles + enhance logs #877

Merged
merged 22 commits into from
Dec 15, 2023
Merged

Reduce noisy reconciles + enhance logs #877

merged 22 commits into from
Dec 15, 2023

Commits on Dec 7, 2023

  1. preliminary changes

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f2c22fa View commit details
    Browse the repository at this point in the history

  2. reconcile machineClass only on addition/deletion 

    of machines
    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b5feb2d View commit details
    Browse the repository at this point in the history

  3. removed double check in secret reconciler

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f8bd6ab View commit details
    Browse the repository at this point in the history

  4. small refactoring

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    db98422 View commit details
    Browse the repository at this point in the history

  5. introduced machine conditions diff logging

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5bdd6bc View commit details
    Browse the repository at this point in the history

  6. removed old in-tree related code

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    e1849e4 View commit details
    Browse the repository at this point in the history

  7. adapted unit tests ot new const 

    errSuccessfulPhaseUpdate
    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b50ff02 View commit details
    Browse the repository at this point in the history

  8. added new retry period ConflictRetry

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0c81be0 View commit details
    Browse the repository at this point in the history

  9. updated log level for better readability

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    61ceccd View commit details
    Browse the repository at this point in the history

  10. some more updated log levels

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    aeb28f7 View commit details
    Browse the repository at this point in the history

  11. adapted test cases

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a672b57 View commit details
    Browse the repository at this point in the history

  12. no machine reconcile on status update

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a653be5 View commit details
    Browse the repository at this point in the history

  13. updated log messages and used ConflictRetry

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0c0aaaf View commit details
    Browse the repository at this point in the history

  14. make generate && make check

    @himanshu-kun
    himanshu-kun committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f606092 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. reconcile on removal of critical component taint

    @himanshu-kun
    himanshu-kun committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    41b8a73 View commit details
    Browse the repository at this point in the history

  2. reconcile machine on specific node taint updates

    @himanshu-kun
    himanshu-kun committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    2099f97 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. adapted unit tests for create errors

    @himanshu-kun
    himanshu-kun committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    692e894 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. fixed some failing tests

    @himanshu-kun
    himanshu-kun committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    174a4b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Francis Fernandes <79958509+aaronfern@users.noreply.github.com>
Co-authored-by: Rishabh Patel <66425093+rishabh-11@users.noreply.github.com>
    @himanshu-kun @aaronfern @rishabh-11
    3 people authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ca12dd0 View commit details
    Browse the repository at this point in the history

  2. addresed Rishab's suggestion part 1

    @himanshu-kun
    himanshu-kun committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b73c147 View commit details
    Browse the repository at this point in the history

  3. addressed Rishab's review comments part 2

    @himanshu-kun
    himanshu-kun committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9d41bf7 View commit details
    Browse the repository at this point in the history

  4. renamed updateRetryRequired to updateRetryPeriod

    @himanshu-kun
    himanshu-kun committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c93ce96 View commit details
    Browse the repository at this point in the history