Upgrade k8s dependencies to v0.29.3, Fix yaml parsing issues
#907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
rishabh-11
changed the title
v0.29.3v0.29.3, Fix yaml parsing issues
elankath
reviewed
Apr 19, 2024
pkg/controller/deployment_util.go
Outdated
|
|
||
| klog.V(4).Infof("calculating proportion increase for machineSet %s. ms.desired=%d, maxDeploymentSizePossible=%d, maxDeploymentSizePossibleAsPerAnnotation=%d", is.Name, deploymentReplicas, annotatedReplicas) | ||
| return integer.RoundToInt32(newISsize) - (is.Spec.Replicas) | ||
| klog.V(4).Infof("calculating proportion increase for machineSet %s. ms.desired=%d, maxDeploymentSizePossible=%d, maxDeploymentSizePossibleAsPerAnnotation=%d", is.Name, newISsize, deploymentReplicas, annotatedReplicas) |
There was a problem hiding this comment.
Should log level be 3 or 4 here ? I mean this changed log won't be visible by default. Is that desired ?
elankath
reviewed
Apr 19, 2024
| if f == "\n" || f == "" { | ||
| // ignore empty cases | ||
| continue | ||
| if fileAsString == "\n" || fileAsString == "" { |
There was a problem hiding this comment.
we should take note to add a unit-test to ParseK8sYaml in the future . This is a big function and it is difficult to judge changes.
There was a problem hiding this comment.
Ideally we should break it down to ParseK8sCRD, ParseMachineResources and ParseOtherK8sResources or something like this.
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
elankath
approved these changes
Apr 19, 2024
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade k8s dependencies to
v0.29.3. This is needed as we have upgraded controller-gen to v0.14.0 and it is not working withv0.28.2of k8s dependencies. It also fixes the yaml parsing issue introduced due to updating controller-gen to0.14.0Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
IT tests pass (cc @sssash18 )
Release note: