-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary body recording #70
Conversation
757d03e
to
4aae96b
Compare
During recording a S3 object retrieving request the library raises `TypeError` while the response is totally valid. Response json data is copied including streaming body to handle potential issues with binary data without affecting original binary payload.
4aae96b
to
154174b
Compare
23670ec
to
7b1fc1f
Compare
7b1fc1f
to
901dd26
Compare
c8f853b
to
0616d35
Compare
0616d35
to
2a595c8
Compare
@garnaat We started hitting this issue too. Could this PR be merged? |
There are some merge conflicts at the moment. If the author wants to resolve those, that would be great. Otherwise I can do it and get it merged. |
+1 just ran into this error too. Would be great if you could merge |
Another +1 to the mix, ran into this while recording a session that pulls a file from S3. |
+1 running into this issue to with AppConfig. |
* Updating supported Python versions * Trying another approach to fix PR #70. * Removing caveman debug print statements. Co-authored-by: Mitch Garnaat <garnaat@amazon.com>
This should be fixed with a different approach in #79 |
During recording a S3 object retrieving request the library raises TypeError while the response is totally valid and changing actual response, thus request couldn't be finished.