Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #8

Merged
merged 30 commits into from
Dec 19, 2019
Merged

Dev #8

merged 30 commits into from
Dec 19, 2019

Conversation

bshifaw
Copy link

@bshifaw bshifaw commented Dec 17, 2019

  • Updated WDLs to 1.0
  • Removed GenerateOutputMap from bam2ubam because "this is not the best way to extract readgroup IDs. One issue is if other lines in the header contain the characters @rg, they will be caught here."
  • Removed fc version of fastq2ubam because updates to Terra make working Data tables easier. Creating a seperate file with sample metadata isn't necessary.
  • Added default variables to cram2bam

bshifaw added 28 commits February 23, 2018 18:24
removed gatk software requiremnt because repo will contain more than one wdl which may use different versions.
…ile containing a list of the generated ubams
…fc version of fastq2ubam, added defaults to cram2bam
Copy link

@kachulis kachulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the bam-to-unmapped-bams.wdl part, which looks good.

bam-to-unmapped-bams.wdl Show resolved Hide resolved
bam-to-unmapped-bams.wdl Outdated Show resolved Hide resolved
@bshifaw bshifaw merged commit 088149a into master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants