GraphQL 16 forward compatibility #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make compatible with GraphQL 16
aaronadamsCA
changed the title
|
@LekoArts @aaronadamsCA is there a reason why this is not merged yet? trying to use the toolkit but I'm getting the same error on #47, I have tested the generated fragments against the remote Graphql and they work, but since compileNodeQueries fails I couldn't test the compiled queries.
|
|
@AbdallahAbis I patched the package locally, which you can also do with |
LekoArts
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47.
I applied this locally as a monkey patch, and it works perfectly. I haven't identified any other issues with GraphQL forward compat.
(This patch was so simple that I literally typed it into GitHub, so just make sure I didn't make any silly typos.)