fix(gatsby): always respond with index html without checking path #11400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
force-pushed
the
fix/always-respond-with-index-html-in-develop
branch
from
d1d2369
to
57a9135
Compare
wardpeet
approved these changes
Jan 31, 2019
wardpeet
pushed a commit
that referenced
this pull request
Feb 11, 2019
…1400) During develop, we currently check path before returning our static html: https://github.com/gatsbyjs/gatsby/blob/aa4f9397665d6d1e7ea6cdd3bfd6f40b449daccf/packages/gatsby/src/commands/develop.js#L192 This seems unnecessary because if all handlers above haven't responded to the request yet (webpack dev middleware, express static etc) it is safe to say that the request _needs_ to be handled here. Currently the checks for path and non-exhaustive and we miss out of complicated cases like /reference/mono-v6.x.x (directory) Fixes #11348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During develop, we currently check path before returning our static html:
gatsby/packages/gatsby/src/commands/develop.js
Line 192 in aa4f939
This seems unnecessary because if all handlers above haven't responded to the request yet (webpack dev middleware, express static etc) it is safe to say that the request needs to be handled here.
Currently the checks for path and non-exhaustive and we miss out of complicated cases like /reference/mono-v6.x.x (directory)
Fixes #11348