Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): Showcase categories css fix. #11644

Closed

Conversation

tsvetlin
Copy link
Contributor

@tsvetlin tsvetlin commented Feb 8, 2019

Description

I found an issue, on the Showcase site, categories were invisible on some browsers.
Details of the issue are in #11574

Related Issues

Link to the issue that is fixed by this PR (if there is one)
Fixes: #11574

…lector, this way some categories were missing.
@tsvetlin tsvetlin requested a review from a team as a code owner February 8, 2019 11:58
@DSchau DSchau added the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Feb 8, 2019
@DSchau
Copy link
Contributor

DSchau commented Feb 8, 2019

Thanks for this!

@tsvetlin I commented on the original issue--could you provide a clearer reproduction? Unsure how to reproduce the original issue, so unsure if we need the fix! Thanks!

@DSchau DSchau added the status: awaiting author response Additional information has been requested from the author label Feb 8, 2019
@wardpeet
Copy link
Contributor

Thanks so much for the PR!

It seems like #12449 fixes this PR more correctly and is indeed a firefox issue.

We want you to know that we certainly want to keep you as a contributor to Gatsby, so we'd encourage you to check out our open issues.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪 💜

@wardpeet wardpeet closed this Mar 12, 2019
wardpeet pushed a commit that referenced this pull request Mar 12, 2019
…irefox (#12449)

## Description

Collapsible component (the checkboxes in https://www.gatsbyjs.org/showcase/) isn’t scrolling properly in Firefox.

## Related Issues
#11574 
#11644
wardpeet pushed a commit that referenced this pull request Mar 12, 2019
…irefox (#12449)

## Description

Collapsible component (the checkboxes in https://www.gatsbyjs.org/showcase/) isn’t scrolling properly in Firefox.

## Related Issues
#11574 
#11644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(www): Gatsby Showcase site categories sticking out from the page.
3 participants