Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update GraphQL description in Tutorial Part Zero #12962

Merged
merged 2 commits into from
Apr 15, 2019

Conversation

ozanmuyes
Copy link
Contributor

Description

Update GraphQL description on "Overview of core technologies" subtitle.

Originally A query language. A programming language that allows you to pull data into your website. was written. The current explanation is confusing to me and I think it contradictory; is it a query language or a programming language. I'd go with the first one.

Also as of my observations just GraphQL is not sufficient to pull data, there must be an implementation on top it (e.g. Apollo Server).

Update GraphQL description on "Overview of core technologies" subtitle.

Originally `A query language. A programming language that allows you to pull data into your website.` was written. The current explanation is confusing to me and I think it contradictory; is it a query language or a _programming language_. I'd go with the first one.

Also as of my observations just GraphQL is not sufficient to pull data, there must be an implementation on top it (e.g. Apollo Server).
@ozanmuyes ozanmuyes requested a review from a team March 31, 2019 04:59
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree that GraphQL is (only) a query language (as per https://graphql.org/learn/)

@LekoArts LekoArts changed the title Update GraphQL description fix(docs): Update GraphQL description in Tutorial Part Zero Apr 15, 2019
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 15, 2019
@LekoArts LekoArts merged commit 08ed630 into gatsbyjs:master Apr 15, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 15, 2019

Holy buckets, @ozanmuyes — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@ozanmuyes
Copy link
Contributor Author

It was a small correction but happy to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants