fix(gatsby-telemetry): Ensure we capture cli version even with older gatsby-cli #13087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
approved these changes
Apr 3, 2019
wardpeet
reviewed
Apr 5, 2019
wardpeet
added
the
status: awaiting author response
currently loaded.
jamo
added
status: awaiting reviewer response
wardpeet
reviewed
Apr 11, 2019
| try { | ||
| const jsonfile = join( | ||
| require | ||
| .resolve(`gatsby-cli`) // Resolve where current gatsby-cli would be loaded from. |
There was a problem hiding this comment.
nice find! Let me test this 😄
|
Seems to work on windows which means it works everywhere 😂 PS C:\Users\WardPeeters\Projects\tmp\starters-win> yarn develop
yarn run v1.15.2
$ gatsby develop
Captured event: {"installedGatsbyVersion":"2.3.3","gatsbyCliVersion":"2.5.3","eventType":"CLI_COMMAND_DEVELOP","sessionId":"1764fe90-5c4e-11e9-b4ec-47e7cc250396","time":"2019-04-11T11:36:48.326Z","machineId":"f9a0d0b0-4fbd-11e9-8674-c75bf48574c3","repositoryId":"pwd:7423156cafd3d0452d360b57de4d4f0017ff86eddce45f6d5a4adc0d068520be","componentId":"gatsby-cli","osInformation":{"nodeVersion":"v8.15.1","platform":"win32","release":"10.0.17763","cpus":"Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz","arch":"x64","ci":false},"componentVersion":"1.0.4"}
$ C:\Users\WardPeeters\Projects\tmp\starters-win\node_modules\.bin\gatsby --version
2.3.3PS C:\Users\WardPeeters\Projects\tmp\starters-win> npx gatsby-cli develop
Captured event: {"installedGatsbyVersion":"2.3.3","gatsbyCliVersion":"2.5.6","eventType":"CLI_RAW_COMMAND_DEVELOP","sessionId":"8f677f80-5c4e-11e9-a0d9-bfaeaa5cd52f","time":"2019-04-11T11:40:09.595Z","machineId":"f9a0d0b0-4fbd-11e9-8674-c75bf48574c3","repositoryId":"pwd:7423156cafd3d0452d360b57de4d4f0017ff86eddce45f6d5a4adc0d068520be","componentId":"gatsby-cli","osInformation":{"nodeVersion":"v8.15.1","platform":"win32","release":"10.0.17763","cpus":"Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz","arch":"x64","ci":false,"docker":false},"componentVersion":"1.0.6"}
PS C:\Users\WardPeeters\Projects\tmp\starters-win> npx gatsby-cli --version
2.5.6 |
DSchau
pushed a commit
that referenced
this pull request
Apr 15, 2019
…tal prototypes (#13368) There is issue in one of dependency of currently used `asciidoctor` package version. Recommendation from `asciidoctor` maintainer was to bump package version ( asciidoctor/asciidoctor.js#651 (comment) ), which I did and tested using reproduction from #13087 and our `using-asciidoc` example. fixes #13097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies over the version metadata collection from
gatsby-cli/src/createCli.js