Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(showcase): add Gold Medal Flour to site showcase #13397

Merged
merged 2 commits into from
Apr 16, 2019
Merged

chore(showcase): add Gold Medal Flour to site showcase #13397

merged 2 commits into from
Apr 16, 2019

Conversation

thadroe
Copy link
Contributor

@thadroe thadroe commented Apr 16, 2019

Description

Related Issues

@thadroe thadroe requested a review from a team April 16, 2019 18:43
@DSchau DSchau changed the title Add Gold Medal Flour to site showcase chore(showcase): add Gold Medal Flour to site showcase Apr 16, 2019
DSchau
DSchau approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great looking site! Thanks for sharing!!

docs/sites.yml
main_url: https://www.goldmedalflour.com
url: https://www.goldmedalflour.com
description: >
Gold Medal Four is a brand of flour products owned by General Mills. The new site was built using Gatsby v2 with data sources from Wordpress and an internal recipe API, and features multifaceted recipe filtering and a modified version of Gatsby Image to support art direction images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey cool -- we're actually working on this right now. Any insight into that would be super valuable!

#13395

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sweet! Glad to see it being worked on! I'll check out that PR and see if I can offer up anything. What I did for this might be a little on the crude side, but essentially what I ended up doing is copying modifying the default Gatsby Image component and used styled components, also adding an option for a custom breakpoint prop. I put it up here just now if you want to have a look.

https://github.com/thadroe/art-direction-images-for-gatsby

@DSchau DSchau merged commit ec2d07d into gatsbyjs:master Apr 16, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 16, 2019

Holy buckets, @thadroe — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@thadroe thadroe deleted the add-goldmedalflour-to-showcase branch April 17, 2019 15:02
@brimtown brimtown mentioned this pull request Apr 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thadroe @DSchau @lannonbr