Update Deploying to Heroku docs #14811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instructions for adding buildpacks here are going to result in errors and confusion. `heroku buildpacks:set` sets a single buildpack so running it twice will override the first one. I've changed the instructions to still run `heroku buildpacks:set heroku/nodejs` first which will ensure `heroku/nodejs` is the only buildpack set, then run `heroku buildpacks:add https://github.com/heroku/heroku-buildpack-static.git` so it will add it as a second buildpack. (the difference being `buildpacks:add` in the second command) `app.json` is only honored for the heroku button and review apps so it should be specified as optional. I replaced the ambiguous "sometimes this doesn't work" comment with more details about when you might want to use it and a link to the heroku platform api article which covers `app.json`.
freiksenet
added
the
bot: merge on green
|
Holy buckets, @gpspake — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
The instructions for adding buildpacks here are going to result in errors and confusion. `heroku buildpacks:set` sets a single buildpack so running it twice will override the first one. I've changed the instructions to still run `heroku buildpacks:set heroku/nodejs` first which will ensure `heroku/nodejs` is the only buildpack set, then run `heroku buildpacks:add https://github.com/heroku/heroku-buildpack-static.git` so it will add it as a second buildpack. (the difference being `buildpacks:add` in the second command) `app.json` is only honored for the heroku button and review apps so it should be specified as optional. I replaced the ambiguous "sometimes this doesn't work" comment with more details about when you might want to use it and a link to the heroku platform api article which covers `app.json`.
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 17, 2019
The instructions for adding buildpacks here are going to result in errors and confusion. `heroku buildpacks:set` sets a single buildpack so running it twice will override the first one. I've changed the instructions to still run `heroku buildpacks:set heroku/nodejs` first which will ensure `heroku/nodejs` is the only buildpack set, then run `heroku buildpacks:add https://github.com/heroku/heroku-buildpack-static.git` so it will add it as a second buildpack. (the difference being `buildpacks:add` in the second command) `app.json` is only honored for the heroku button and review apps so it should be specified as optional. I replaced the ambiguous "sometimes this doesn't work" comment with more details about when you might want to use it and a link to the heroku platform api article which covers `app.json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The instructions for adding buildpacks here could result in some errors and confusion.
heroku buildpacks:setsets a single buildpack so running it twice will override the first one.I've changed the instructions to still run
heroku buildpacks:set heroku/nodejsfirst which will ensureheroku/nodejsis the only buildpack set, then runheroku buildpacks:add https://github.com/heroku/heroku-buildpack-static.gitso it will add it as a second buildpack. (the difference beingbuildpacks:addin the second command)app.jsonis only honored for the heroku button and review apps so it should be specified as optional.I replaced the ambiguous "sometimes this doesn't work" comment with more details about when you might want to use it and a link to the heroku platform api article which covers
app.json.