Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-cli): depend upon @hapi/joi #15221

Merged
merged 2 commits into from
Jun 28, 2019
Merged

fix(gatsby-cli): depend upon @hapi/joi #15221

merged 2 commits into from
Jun 28, 2019

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Jun 28, 2019

Description

Fixes #15220

Note: we now depend upon different versions of @hapi/joi but that should be fine.

=> Found "@hapi/joi@14.5.0"
info Has been hoisted to "@hapi/joi"
info Reasons this module exists
   - "workspace-aggregator-1d652547-46c4-4b25-9983-c166b546202f" depends on it
   - Hoisted from "_project_#gatsby-plugin-feed#@hapi#joi"
   - Hoisted from "_project_#gatsby-source-contentful#@hapi#joi"
   - Hoisted from "_project_#gatsby#@hapi#joi"
info Disk size without dependencies: "312KB"
info Disk size with unique dependencies: "520KB"
info Disk size with transitive dependencies: "568KB"
info Number of shared dependencies: 5
=> Found "gatsby-cli#@hapi/joi@15.1.0"
info This module exists because "_project_#gatsby-cli" depends on it.

Related Issues

@DSchau DSchau requested a review from a team as a code owner June 28, 2019 18:21
pieh
pieh previously approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

pieh
pieh approved these changes Jun 28, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮

@DSchau DSchau mentioned this pull request Jun 28, 2019
Closed
@pieh pieh merged commit 59a021d into gatsbyjs:master Jun 28, 2019
@DSchau DSchau deleted the fix/gatsby-cli-joi branch June 28, 2019 18:55
johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
@DSchau @johno
fix(gatsby-cli): depend upon @hapi/joi (gatsbyjs#15221)
ed17011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'joi'
2 participants
@DSchau @pieh