Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-remark): Restore pathPrefix option in remark plugins #15889

Merged
merged 1 commit into from
Jul 19, 2019
Merged

fix(gatsby-transformer-remark): Restore pathPrefix option in remark plugins #15889

merged 1 commit into from
Jul 19, 2019

Conversation

trevorblades
Copy link
Contributor

Description

This branch resolves an issue where gatsby-transformer-remark is no longer supplying the configured pathPrefix to Gatsby Remark plugins. This is happening because in this commit, the pathPrefix variable was replaced with basePath, but pathPrefix was left in the destructured function argument.

Since the destructured pathPrefix variable isn't being used within the function, I removed it. This causes the property to remain in the ...rest object, which in turn gets spread into the options provided to Gatsby remark plugins here.

Related Issues

Fixes #15787

@trevorblades trevorblades requested a review from a team as a code owner July 18, 2019 23:48
@trevorblades trevorblades mentioned this pull request Jul 18, 2019
Closed
@trevorblades trevorblades changed the title Keep pathPrefix in ...rest so it gets passed to plugins fix(gatsby-transformer-remark) Continue passing pathPrefix to plugins Jul 18, 2019
@trevorblades trevorblades changed the title fix(gatsby-transformer-remark) Continue passing pathPrefix to plugins fix(gatsby-transformer-remark): Continue passing pathPrefix to plugins Jul 18, 2019
@trevorblades trevorblades changed the title fix(gatsby-transformer-remark): Continue passing pathPrefix to plugins fix(gatsby-transformer-remark): Restore pathPrefix option in remark plugins Jul 18, 2019
@trevorblades trevorblades added topic: plugins type: bug An issue or pull request relating to a bug in Gatsby labels Jul 19, 2019
DSchau
DSchau approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke this 😬

Thanks!

@DSchau DSchau merged commit 81b6cf1 into gatsbyjs:master Jul 19, 2019
@trevorblades trevorblades deleted the gatr-plugins-path-prefix branch July 19, 2019 00:35
@DSchau
Copy link
Contributor

DSchau commented Jul 19, 2019

Published as gatsby-transformer-remark@2.6.7

@xavivars
Copy link
Contributor

@DSchau, actually, I think it was me who broke it, by trying to fix something else... Sorry about that.

johno pushed a commit to johno/gatsby that referenced this pull request Jul 29, 2019
@trevorblades @johno
fix(gatsby-transformer-remark): Restore pathPrefix option in r… (gats…
432d12b 
…byjs#15889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-remark-images prefixPaths no longer work!
3 participants
@trevorblades @DSchau @xavivars