chore(e2e-tests): Only record cypress runs on CI #16190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
changed the title
pieh
approved these changes
Jul 30, 2019
|
Yeah. We should definitely clean up this once cypress supports passing in the record options via the config json or an env variable @pieh |
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently end to end tests don't work locally when run via
yarn testbecause cypress complains of being called with--recordbut without a secret and project IDSince cypress dashboard secrets and project IDs are in Circle CI config and we shouldn't record local cypress runs IMO anyway, this PR checks you're on CI and only then passes in
--recordwhen running cypress